From 0e82988d6f32b6d09e54ecf547b6c562fe1d2009 Mon Sep 17 00:00:00 2001
From: Akib Azmain Turja <akib@disroot.org>
Date: Tue, 29 Nov 2022 00:13:58 +0600
Subject: [PATCH] Use 'setf' + 'plist-get' instead of 'plist-put'
* eat.el (eat--eshell-adjust-make-process-args): Use (setf (plist-get
...) ...) instead of 'plist-put' without taking the result, which is
not guaranteed to always work.
---
eat.el | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/eat.el b/eat.el
index 560b37b..00928ff 100644
--- a/eat.el
+++ b/eat.el
@@ -6129,17 +6129,16 @@ modify its argument to change the filter, the sentinel and invoke
(expand-file-name command))
args))))
(apply make-process plist)
- (plist-put plist :filter #'eat--eshell-filter)
- (plist-put plist :sentinel #'eat--eshell-sentinel)
- (plist-put
- plist :command
- `("/usr/bin/env" "sh" "-c"
- ,(format "stty -nl echo rows %d columns %d \
+ (setf (plist-get plist :filter) #'eat--eshell-filter
+ (plist-get plist :sentinel) #'eat--eshell-sentinel
+ (plist-get plist :command)
+ `("/usr/bin/env" "sh" "-c"
+ ,(format "stty -nl echo rows %d columns %d \
sane 2>%s ; if [ $1 = .. ]; then shift; fi; exec \"$@\""
- (window-text-height)
- (window-max-chars-per-line) null-device)
- ".."
- ,@(plist-get plist :command)))
+ (window-text-height)
+ (window-max-chars-per-line) null-device)
+ ".."
+ ,@(plist-get plist :command)))
(let ((process (apply make-process plist)))
(eat--eshell-setup-proc-and-term process)
process)))))